[LinuxBIOS] r2935 - trunk/LinuxBIOSv2/src/northbridge/amd/amdk8

Peter Stuge peter at stuge.se
Sat Nov 3 03:05:34 CET 2007


On Sat, Nov 03, 2007 at 12:27:12AM +0100, svn at openbios.org wrote:
> Log:
> This patch changes the "if else" style of parameter matching to
> table and also changes the rdpreamble parameter, which will cause
> that more then one DIMM will work for 939 motherboard.

\o/


> -		dcl |= DCL_UnBufDimm;
> +		if ((has_dualch) && (!is_cpu_pre_d0())) {
> +			dcl |= DCL_UnBufDimm; /* set DCL_DualDIMMen too? */
> +			
> +			/* set DCL_En2T if you have non-equal DDR mem types! */
> +			
> +			if ((cpuid_eax(1) & 0x30) == 0x30) {
> +				/* CS[7:4] is copy of CS[3:0], should be set for 939 socket */
> +				dcl |= DCL_UpperCSMap;
> +			}
> +		} else {
> +			dcl |= DCL_UnBufDimm;
> +		}

This isn't super neat, the else could be removed.


//Peter




More information about the coreboot mailing list