[LinuxBIOS] [PATCH] fix port 0 on sata controller 0 for ck804 based boards

Uwe Hermann uwe at hermann-uwe.de
Sun Nov 18 17:07:42 CET 2007

On Thu, Nov 15, 2007 at 09:34:33PM -0800, yhlu wrote:
> > I'm not 100% sure why both the ck804_early_setup.c and the
> > ck804_early_setup_car.c file are included in the mainboards/sunw/ultra40/
> > tree; probably only one of those files is actually used.
> we can delete non car version for now, because ck804 and mcp55 based
> all go with car auto main.

Agreed, I think we should drop all romcc-related code from boards which
already do support CAR in v2. In v3 all boards _must_ use CAR anyway.

As for ck804_early_setup.c, the A8N-E still uses it at the moment.
With this patch in cache_as_ram_auto.c I tested the SATA ports again
and I see no changes (3+4 work, 1+2 don't).

-#include "southbridge/nvidia/ck804/ck804_early_setup.c"
+#include "southbridge/nvidia/ck804/ck804_early_setup_car.c"

So shall we move all boards to ck804_early_setup_car.c for now and
drop ck804_early_setup.c completely?

(btw, could ck804_early_setup.c affect other things than just SATA?
I only tested the SATA ports so far)

Thanks, Uwe.
http://www.hermann-uwe.de  | http://www.holsham-traders.de
http://www.crazy-hacks.org | http://www.unmaintained-free-software.org

More information about the coreboot mailing list