[LinuxBIOS] [PATCH] v3: fix compilation due to multiple definitions of printk

Uwe Hermann uwe at hermann-uwe.de
Thu Nov 22 23:55:48 CET 2007

On Thu, Nov 22, 2007 at 09:44:03PM +0100, Carl-Daniel Hailfinger wrote:
> The introduction of the _SHARED macros had one flaw: If multiple files
> had _SHARED defined during compilation, each of them would contain an
> assignment of stage0_printk to *printk. During linking, this caused
> errors as multiple definitions of printk existed.
> Make sure _SHARED alone gives you only the printk prototype, and iff
> _MAINOBJECT is defined as well, include the assignment.
> Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net>

Great, thanks a lot!

Committed in r516, and I added the commit message as comment too,
it's very useful to understand what's going on in that file IMO.

I tested this and can confirm that all v3 targets build fine now.

http://www.hermann-uwe.de  | http://www.holsham-traders.de
http://www.crazy-hacks.org | http://www.unmaintained-free-software.org

More information about the coreboot mailing list