[LinuxBIOS] [PATCH] v3: Various cleanups
Corey Osgood
corey.osgood at gmail.com
Mon Nov 26 02:12:25 CET 2007
Uwe Hermann wrote:
> See patch.
>
>
> Uwe.
>
Did Carl-Daniel's documentation fixes make it in yet?
> Index: mainboard/emulation/qemu-x86/vga.c
> ===================================================================
> --- mainboard/emulation/qemu-x86/vga.c (Revision 518)
> +++ mainboard/emulation/qemu-x86/vga.c (Arbeitskopie)
> @@ -32,11 +32,14 @@
> struct pc_keyboard conf;
>
> printk(BIOS_INFO, "Init VGA device\n");
> +
> dev->on_mainboard = 1;
> dev->rom_address = 0xc0000;
>
> - // FIXME - this should be in superio some day
> - // but since qemu has no superio.
> + /*
> + * FIXME: This should be in superio some day
>
Comma please
> + * but since QEMU has no superio...
> + */
> init_pc_keyboard(0x60, 0x64, &conf);
> }
> Index: README
> ===================================================================
> --- README (Revision 518)
> +++ README (Arbeitskopie)
> @@ -102,7 +102,7 @@
> The 'flashrom' tool is located in util/flashrom where you can build it
> from source code by typing 'make'. Alternatively, your favorite Linux
> distribution might ship a 'flashrom' package which provides the 'flashrom'
> - program in (e.g.) /usr/bin. On Debian GNU/Linux systems you can get
> + program in /usr/sbin. On Debian GNU/Linux systems you can get
> the flashrom package via 'apt-get install flashrom'.
Does every distribution out there provide it in /usr/sbin? If not,
please leave the (e.g.). Other than those and if Carl-Daniel's patches
have been applied,
Acked-by: Corey Osgood <corey.osgood at gmail.com>
More information about the coreboot
mailing list