[LinuxBIOS] [PATCH] v3: Various cleanups

[Uwe Hermann]

[Please post all replies on the mailing list]

On Mon, Nov 26, 2007 at 07:36:31PM +0100, Paul Menzel wrote:
> Hi,
> 
> 
> small typos I think.
> 
> 
> Am Montag, den 26.11.2007, 00:54 +0000 schrieb Uwe Hermann:
> 
>  /**
> -  * Place holder in case we ever need it. Since this file is a
> -  * template for other motherboards, we want this here and we want the
> -  * call in the right place.
> -  */
> -
> + * Place holder in case we ever need it. Since this file is a template for
> 
> Placeholder

Fixed.


> + * other boards, we want this here and we want the call in the right place.
> + */
>  static void mb_gpio_init(void)
>  {
>         /* Early mainboard specific GPIO setup */
>  }
> 
> -       /* NOTE: must do this AFTER the early_setup!
> -        * it is counting on some early MSR setup
> -        * for cs5536.
> +       /*
> +        * NOTE: Must do this AFTER the early_setup! It is counting on some
> +        * early MSR setup for the CS5536. We do this early for debug. 
> +        * Real setup should done in chipset init via Config.lb.
> 
> should be done

Fixed.


> Index: README
> ===================================================================
> --- README      (Revision 518)
> +++ README      (Arbeitskopie)
> 
> -  program in (e.g.) /usr/bin. On Debian GNU/Linux systems you can get
> +  program in /usr/sbin. On Debian GNU/Linux systems you can get
>    the flashrom package via 'apt-get install flashrom'.
> 
> aptitude

That's more a matter of taste.


Thanks, Uwe.
-- 
http://www.hermann-uwe.de  | http://www.holsham-traders.de
http://www.crazy-hacks.org | http://www.unmaintained-free-software.org