[LinuxBIOS] [PATCH] v3: big arch/x86/stage1.c and lib/lar.c cleanup

Stefan Reinauer stepan at coresystems.de
Thu Nov 29 10:56:24 CET 2007


* Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net> [071128 00:52]:
> Consolidate all multiple segment handling into
> lib/lar.c:load_file_segments() and greatly simplify arch/x86/stage1.c
> code as a result. While I'm at it, improve the LAR segmentation
> abstraction. Stage 1 code should not have to care about internal
> representation of segments, that knowledge belongs into lib/lar.c.
> Constification of most function parameters in lib/lar.c led to a few
> other now obvious code removals.
> 
> Build tested and runtime tested in Qemu.
> 
> Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net>

>> Index: LinuxBIOSv3-betterlarsegments/arch/x86/stage1.c
> ===================================================================
> --- LinuxBIOSv3-betterlarsegments/arch/x86/stage1.c	(Revision 529)
> +++ LinuxBIOSv3-betterlarsegments/arch/x86/stage1.c	(Arbeitskopie)
> @@ -161,11 +160,9 @@
>  	/* Turn off Cache-As-Ram */
>  	disable_car();
>  
> -	entry = load_file(&archive, "normal/stage2.o/segment0");
> +	entry = load_file_segments(&archive, "normal/stage2.o");

please remove ".o" -- these are NOT .o files.


-- 
coresystems GmbH • Brahmsstr. 16 • D-79104 Freiburg i. Br.
      Tel.: +49 761 7668825 • Fax: +49 761 7664613
Email: info at coresystems.dehttp://www.coresystems.de/
Registergericht: Amtsgericht Freiburg • HRB 7656
Geschäftsführer: Stefan Reinauer • Ust-IdNr.: DE245674866




More information about the coreboot mailing list