[LinuxBIOS] [PATCH] v3: reorder rules in mainboard/*/*/Makefile
Carl-Daniel Hailfinger
c-d.hailfinger.devel.2006 at gmx.net
Fri Nov 30 23:19:26 CET 2007
On 30.11.2007 23:00, Stefan Reinauer wrote:
> Carl-Daniel Hailfinger wrote:
>
>> On 29.11.2007 11:23, Stefan Reinauer wrote:
>>
>>
>>> * Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net> [071128 01:20]:
>>>
>>>
>>>
>>>> Reorder the rules in mainboard/*/*/Makefile so their order is identical
>>>> across all of these makefiles. The rules are now in order of execution
>>>> during boot, that is:
>>>> STAGE0_MAINBOARD_OBJ
>>>> INITRAM_OBJ
>>>> STAGE2_MAINBOARD_OBJ
>>>> As added benefit, mainboard makefiles are now almost identical.
>>>>
>>>> Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net>
>>>>
>>>>
>>>>
>>> While you are at it, could you also change the _OBJ collections to
>>> gather source files instead?
>>>
>>> In case of initram, the filenames in INITRAM_OBJ are changed on the fly,
>>> so that's misleading. Generating a list of source files looks clearer,
>>> and can accordingly replaced when being used
>>> $(patsubst %.c,$(obj)/%_xip.o,$(INITRAM_SOURCE))
>>>
>>>
>>>
>> I'd prefer to do that in a separate patch. Is that OK for you?
>>
>>
> any time :-)
>
Do I get an Ack for this patch?
Regards,
Carl-Daniel
More information about the coreboot
mailing list