[LinuxBIOS] [PATCH] fix resource end in K8 amdk8/northbridge.c

Uwe Hermann uwe at hermann-uwe.de
Mon Oct 1 22:43:35 CEST 2007


On Sat, Sep 29, 2007 at 02:02:48AM +0200, Rudolf Marek wrote:
> Index: src/northbridge/amd/amdk8/northbridge.c
> ===================================================================
> --- src/northbridge/amd/amdk8/northbridge.c	(revision 2776)
> +++ src/northbridge/amd/amdk8/northbridge.c	(working copy)
> @@ -562,7 +562,7 @@
>  	base  |= (resource->base >> 8) & 0xffffff00;
>  	base  |= 3;
>  	limit &= 0x00000048;
> -	limit |= ((resource->base + resource->size) >> 8) & 0xffffff00;
> +	limit |= (resource_end(resource) >> 8) & 0xffffff00;
>  	limit |= (resource->index & 3) << 4;
>  	limit |= (nodeid & 7);
>  	f1_write_config32(reg + 0x4, limit);

What exactly is broken in the current code and how does it show? How can
we test the effect of the fix?


Thanks, Uwe.
-- 
http://www.hermann-uwe.de  | http://www.holsham-traders.de
http://www.crazy-hacks.org | http://www.unmaintained-free-software.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20071001/51075cd2/attachment.sig>


More information about the coreboot mailing list