[LinuxBIOS] [PATCH] fix resource end in K8 amdk8/northbridge.c

Carl-Daniel Hailfinger c-d.hailfinger.devel.2006 at gmx.net
Tue Oct 2 16:23:06 CEST 2007


On 01.10.2007 22:43, Uwe Hermann wrote:
> On Sat, Sep 29, 2007 at 02:02:48AM +0200, Rudolf Marek wrote:
>> Index: src/northbridge/amd/amdk8/northbridge.c
>> ===================================================================
>> --- src/northbridge/amd/amdk8/northbridge.c	(revision 2776)
>> +++ src/northbridge/amd/amdk8/northbridge.c	(working copy)
>> @@ -562,7 +562,7 @@
>>  	base  |= (resource->base >> 8) & 0xffffff00;
>>  	base  |= 3;
>>  	limit &= 0x00000048;
>> -	limit |= ((resource->base + resource->size) >> 8) & 0xffffff00;
>> +	limit |= (resource_end(resource) >> 8) & 0xffffff00;
>>  	limit |= (resource->index & 3) << 4;
>>  	limit |= (nodeid & 7);
>>  	f1_write_config32(reg + 0x4, limit);
> 
> What exactly is broken in the current code and how does it show? How can
> we test the effect of the fix?

Resources go backwards (end before start). That should be corrected with
the patch.

I don't have the hardware to verify.

Carl-Daniel




More information about the coreboot mailing list