[LinuxBIOS] flashrom support for AMD Geode CS5536

Jordan Crouse jordan.crouse at amd.com
Tue Oct 2 18:36:25 CEST 2007


On 02/10/07 18:27 +0200, Stefan Reinauer wrote:
> Dear Lane!
> 
> Thank you very much for your patch.
> 
> * Lane Brooks <lbrooks at MIT.EDU> [071002 18:20]:
> > - It seems like there should be a way to revert the msr back after flashing 
> > is completed to put the bios back in write protect mode.  Is there a 
> > cleanup mechanism available?  Something like disable_flash...
> 
> Unfortunately no. Any patches that generically implement such a
> mechanism are welcome though!
> 
> 
> > +#define _LARGEFILE64_SOURCE
> > +#include <sys/types.h>
> > +#include <sys/stat.h>
> > +#include <fcntl.h>
> > +#include <unistd.h>
> 
> > +	unsigned long addr = 0x1808;
> > +	lseek64(fd_msr, (off64_t) addr, SEEK_SET);
> 
> Why do you use/need large file support for seeking to an offset of
> 0x1808 ?

Thats original generic MSR behavior from rdmsr/wrmsr - we need the
large file support to access the high MSRs (0x80000000) and
above.  Its not needed in this case - but is it hurting?

Jordan
-- 
Jordan Crouse
Systems Software Development Engineer 
Advanced Micro Devices, Inc.






More information about the coreboot mailing list