[LinuxBIOS] [PATCH] superiotool: Make --version actually work correctly

Carl-Daniel Hailfinger c-d.hailfinger.devel.2006 at gmx.net
Sat Oct 6 00:00:50 CEST 2007


On 05.10.2007 19:46, Uwe Hermann wrote:
> As the svn keyword $Rev$ is not replaced with the global repository ID
> but rather with the ID of the last commit which changed the
> respective file (where $Rev$ is located), the current --version output
> is incorrect.
> 
> This patch fixes the output by keeping a $Rev$ instance in every file
> (which can be different for every file) and then calculating the
> biggest revision (which is our superiotool version) at runtime when
> superiotool is invoked with --version.
> 
> This only takes *.c and *.h files into account, changes to the README
> and other non-code files will no be reflected in the version number.
> But this is actually a good thing in this case, we don't want to bump
> the version number upon README changes anyway.
> 
> Signed-off-by: Uwe Hermann <uwe at hermann-uwe.de>

Nack. Can we switch back to a more sensible versioning scheme (like 0.1
etc.) or at least ask some svn experts whether there is an easier and
cleaner way to include a revision number?
BTW, the $Rev$ output format is ugly beyond words.

Carl-Daniel




More information about the coreboot mailing list