[LinuxBIOS] [PATCH] superiotool: Make --version actually work correctly

Robinson Tryon bishop.robinson at gmail.com
Sat Oct 6 19:45:24 CEST 2007


On 10/6/07, Stefan Reinauer <stepan at coresystems.de> wrote:
> * Robinson Tryon <bishop.robinson at gmail.com> [071006 17:42]:
> > What about pulling the version directly out of SVN at build time?  Like this:
> >
> > svn info | sed -n 's/.*Revision: \([0-9]*\)/\1/ p'
> >
> > As long as the Makefile lives at the top level of the project, this
> > value should always reflect the latest commit in the current checkout.
>
> unless you svn up certain subdirectories..

I believe that my statement is still correct: the revision in the
binary will reflect the latest commit present in the current checkout.
 Of course, if that commit included files in a subdirectory as well as
at the top level, then you could have the problem of only pulling-down
half of a commit!

The only way I could see this causing a problem would be if someone
tried to build a binary without doing a top-level update.... but that
is pure folly, eh?




More information about the coreboot mailing list