[LinuxBIOS] [PATCH] superiotool: Make --version actually work correctly

Uwe Hermann uwe at hermann-uwe.de
Sun Oct 7 00:27:20 CEST 2007


On Sat, Oct 06, 2007 at 01:53:22PM -0400, Corey Osgood wrote:
> >>> BTW, the $Rev$ output format is ugly beyond words.
> >>>     
> >>>       
> >> Full ack.
> >>
> >> That's why it has to be mangled quite a bit before usage. However, the
> >> final output looks ok IMO:
> >>
> >> $ ./superiotool -v
> >> superiotool r2821


> > Not here it doesn't:
> >
> > amp at hp:~/linuxbios/lb_clean/LinuxBIOSv2/util/superiotool$ ./superiotool -v
> > superiotool r2821�z��
> > amp at hp:~/linuxbios/lb_clean/LinuxBIOSv2/util/superiotool$ ./superiotool -v
> > superiotool r2821����
> > amp at hp:~/linuxbios/lb_clean/LinuxBIOSv2/util/superiotool$ ./superiotool -v
> > superiotool r2821��
> > amp at hp:~/linuxbios/lb_clean/LinuxBIOSv2/util/superiotool$ ./superiotool -v
> > superiotool r2821����
> > amp at hp:~/linuxbios/lb_clean/LinuxBIOSv2/util/superiotool$ ./superiotool -v
> > superiotool r2821�*��
> > amp at hp:~/linuxbios/lb_clean/LinuxBIOSv2/util/superiotool$ ./superiotool -v
> > superiotool r2821�
> > amp at hp:~/linuxbios/lb_clean/LinuxBIOSv2/util/superiotool$ ./superiotool -v
> > superiotool r2821�:��

Hm, is that random junk at the end of the version? In that case there's
a bug somewhere in my code. Should be fixable, though.


> Also just noticed it doesn't work:
> 
> amp at hp:~/linuxbios/lb_clean/LinuxBIOSv2/util/superiotool$ ./superiotool -v
> superiotool r2821�:
> amp at hp:~/linuxbios/lb_clean/LinuxBIOSv2/util/superiotool$ svn info
> Path: .
> URL: svn://linuxbios.org/repos/trunk/util/superiotool
> Repository Root: svn://linuxbios.org/repos
> Repository UUID: 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1
> Revision: 2828
> Node Kind: directory
> Schedule: normal
> Last Changed Author: uwe
> Last Changed Rev: 2828
> Last Changed Date: 2007-10-05 17:58:03 -0400 (Fri, 05 Oct 2007)

That's expected, it won't work until you commit (and do

  $ svn ps svn:keywords "Author Date Id Rev URL" *.[ch]

before committing). That's contained in the patch, but the svn
properties are not applied when you simply use 'patch' to apply
the patch...


Uwe.
-- 
http://www.hermann-uwe.de  | http://www.holsham-traders.de
http://www.crazy-hacks.org | http://www.unmaintained-free-software.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20071007/a5d5c02a/attachment.sig>


More information about the coreboot mailing list