[LinuxBIOS] patch: move shared files to common place

Stefan Reinauer stepan at coresystems.de
Thu Oct 11 20:45:55 CEST 2007


* ron minnich <rminnich at gmail.com> [071011 20:01]:
> On 10/11/07, Uwe Hermann <uwe at hermann-uwe.de> wrote:
> 
> > > Index: amdk8.h
> > > Index: amdk8_f.h
> >
> > Why move these files? And from where to where? They're likely K8
> > specific and located in src/northbridge/amd/amdk8/ (which sounds
> > correct), so why move them?
> >
> 
> that location is specific to one north part, but the files are now
> used by more than one north part. I think the belong in incude/device.

disagreed.

   #include "../../amd/amdk8/amdk8.h"

is the way to go.

Please no hardware specific files in include/device.

Its kinda ugly that the hypertransport support can't easily be disabled
for Via C3/C7 and Intel CPUs already,... 

-- 
coresystems GmbH • Brahmsstr. 16 • D-79104 Freiburg i. Br.
      Tel.: +49 761 7668825 • Fax: +49 761 7664613
Email: info at coresystems.dehttp://www.coresystems.de/
Registergericht: Amtsgericht Freiburg • HRB 7656
Geschäftsführer: Stefan Reinauer • Ust-IdNr.: DE245674866




More information about the coreboot mailing list