[LinuxBIOS] r2853 - trunk/LinuxBIOSv2/src/northbridge/amd/amdk8

svn at openbios.org svn at openbios.org
Sun Oct 14 02:29:25 CEST 2007


Author: uwe
Date: 2007-10-14 02:29:25 +0200 (Sun, 14 Oct 2007)
New Revision: 2853

Modified:
   trunk/LinuxBIOSv2/src/northbridge/amd/amdk8/northbridge.c
Log:
Fix the resource end in amdk8/northbridge.c.

Without this bugfix, the resource for the PCI/ISA video memory at
0xa0000 - 0xbffff is too big, i.e. it goes up to 0xcffff instead of
just 0xbffff as it should.

Here's the diff from two runs of the tool from 
http://www.linuxbios.org/pipermail/linuxbios/2007-June/022449.html
on the MSI MS-7260 (K9N Neo), with and without the bugfix. After applying,
the resource size is correct again.

--- dumpres_lb_pci_vgacard_without_resfix.txt
+++ dumpres_lb_pci_vgacard_with_resfix.txt
@@ -11,7 +11,7 @@
 MMIO map: #2 0x0000000000 - 0x000000ffff Access: /     Dstnode:0 DstLink 0
 MMIO map: #3 0x0000000000 - 0x000000ffff Access: /     Dstnode:0 DstLink 0
 MMIO map: #4 0x0000000000 - 0x000000ffff Access: /     Dstnode:0 DstLink 0
-MMIO map: #5 0x00000a0000 - 0x00000cffff Access: R/W     Dstnode:0 DstLink 0
+MMIO map: #5 0x00000a0000 - 0x00000bffff Access: R/W     Dstnode:0 DstLink 0
 MMIO map: #6 0x00fc000000 - 0x00fd1fffff Access: R/W     Dstnode:0 DstLink 0
 MMIO map: #7 0x00fd200000 - 0x00fd1fffff Access: R/W     Dstnode:0 DstLink 0
 MMIO map: #0  0x000000 - 0x003fff Access: R/W  ISA VGA Dstnode:0 DstLink 0

Signed-off-by: Rudolf Marek <r.marek at assembler.cz>
Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net>
Acked-by: Uwe Hermann <uwe at hermann-uwe.de>



Modified: trunk/LinuxBIOSv2/src/northbridge/amd/amdk8/northbridge.c
===================================================================
--- trunk/LinuxBIOSv2/src/northbridge/amd/amdk8/northbridge.c	2007-10-13 18:06:12 UTC (rev 2852)
+++ trunk/LinuxBIOSv2/src/northbridge/amd/amdk8/northbridge.c	2007-10-14 00:29:25 UTC (rev 2853)
@@ -562,7 +562,7 @@
 	base  |= (resource->base >> 8) & 0xffffff00;
 	base  |= 3;
 	limit &= 0x00000048;
-	limit |= ((resource->base + resource->size) >> 8) & 0xffffff00;
+	limit |= (resource_end(resource) >> 8) & 0xffffff00;
 	limit |= (resource->index & 3) << 4;
 	limit |= (nodeid & 7);
 	f1_write_config32(reg + 0x4, limit);





More information about the coreboot mailing list