[LinuxBIOS] [PATCH] v3: support LARchives with header-after-data
Carl-Daniel Hailfinger
c-d.hailfinger.devel.2006 at gmx.net
Fri Oct 12 23:22:08 CEST 2007
On 12.10.2007 15:05, Peter Stuge wrote:
> On Fri, Oct 12, 2007 at 02:54:41PM +0200, Carl-Daniel Hailfinger wrote:
>
>> The only added code for all new functionality is
>>
>> + if (walk < (char *)header) {
>> + walk = (char *)header;
>> + walk += (sizeof(struct lar_header) + strlen(fullname))
>> + & 0xfffffff0;
>> + }
>>
>> and all other changes are either better code comments or
>> functionally equivalent (whitespace / argument reordering)
>> transformations.
>>
>
> Please make several patches out of that. Easier to review then. :)
>
Will do. Thanks for the review.
Regards,
Carl-Daniel
--
http://www.hailfinger.org/
More information about the coreboot
mailing list