[LinuxBIOS] [PATCH] flashrom: fix wrong values/typos in chipset_enable.c

Carl-Daniel Hailfinger c-d.hailfinger.devel.2006 at gmx.net
Mon Oct 15 02:17:09 CEST 2007


Fix wrong values/typos in chipset_enable.c. This has been confirmed by
Ed Swierk in
http://www.mail-archive.com/linuxbios@linuxbios.org/msg09788.html .

Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net>

---
Ed, can you check whether I got the correction right and ack the patch?

Regards,
Carl-Daniel

Index: util/flashrom/chipset_enable.c
===================================================================
--- util/flashrom/chipset_enable.c	(Revision 2854)
+++ util/flashrom/chipset_enable.c	(Arbeitskopie)
@@ -381,7 +381,7 @@
 
 	/* dump_pci_device(dev); */
 
-	/* Set the 4MB enable bit bit */
+	/* Set the 0-16 MB enable bits */
 	byte = pci_read_byte(dev, 0x88);
 	byte |= 0xff;		/* 256K */
 	pci_write_byte(dev, 0x88, byte);
@@ -389,7 +389,7 @@
 	byte |= 0xff;		/* 1M */
 	pci_write_byte(dev, 0x8c, byte);
 	word = pci_read_word(dev, 0x90);
-	word |= 0x7fff;		/* 15M */
+	word |= 0x7fff;		/* 16M */
 	pci_write_word(dev, 0x90, word);
 
 	old = pci_read_byte(dev, 0x6d);





More information about the coreboot mailing list