[LinuxBIOS] [PATCH] Common code base for Intel 440BX boards

Stefan Reinauer stefan.reinauer at coresystems.de
Sun Oct 21 14:24:32 CEST 2007

Uwe Hermann wrote::
> On Sat, Oct 20, 2007 at 08:44:57PM +0200, Stefan Reinauer wrote:
>> Please put generic 440 code in northbridge/, and not in mainboard/440-base/
>> Having two northbridge directories for the same northbridge sounds complex.
> Full ack. Northbridge-specific code belongs in src/northbridge/*.
> However, this is not northbridge specific code. It's more like "common
> code which somewhat similar mainboards share". Theoretically this could
> include even more (non-440BX) boards which are also similar enough, but
> for now I concentrated on 440BX boards.

Optimally there should only be a config file as the only requirement for 
a mainboard port. But we are not there yet, unfortunately.

These kinds of unifications are false friends IMHO. Packing multiple 
CONFIG_BOARD_*** thingies in one board config file
does not make things easier - at all. It just adds up to the complexity, 
and at some point, namely the migration to linuxbios v3, makes things a 
lot harder than they are now.

Catting 3 files into one and having the C preprocessor split them up 
again is not making things simpler, nor cleaner, nor easier, nor less 
error prone.

Sorry, but I think this is the wrong way to go -- NACK!

> If we later add non-440bx boards (e.g. 430TX or i810 or something) to
> the same framework, we might rename it to xyz-base (but I have no idea
> what a good name for xyz would be ;-)
> Also, I'm a bit undecided if it should be 
>  src/mainboard/common/i440bx-base
> or 
>  src/mainboard/i440bx-base
> (i.e. put the "base" code parts in an extra directory or not). Opinions?
> Uwe.

More information about the coreboot mailing list