[LinuxBIOS] patch 2:corrected alix1c memory size

ron minnich rminnich at gmail.com
Fri Oct 26 18:06:44 CEST 2007


On 10/26/07, Uwe Hermann <uwe at hermann-uwe.de> wrote:

> > +static u8 spd_read_byte(unsigned device, unsigned address)

well, spd address are 10 bits, or 7 bits (*runs away screaming in
fear*) depending on things I don't understand. The addresses? I'm not
sure. Anyone?


> >  {
> > -             return smbus_read_byte(device, address);
> > +     print_debug("spd_read_byte dev ");
> > +     print_debug_hex8(device);
>
> You use *hex8 here, but device is 16 bit above. One of them should
> be fixed.

will do. I just have to figure out which is right.


ron




More information about the coreboot mailing list