[LinuxBIOS] [PATCH] VIA VT8237R support

Corey Osgood corey.osgood at gmail.com
Sun Oct 28 20:03:26 CET 2007

Rudolf Marek wrote:
> Hi all,
>> Sorry I haven't gotten to this yet, been very busy lately. I'll
>> hopefully be back at work on the cn700 tomorrow, trying to get it ready
>> to go in the tree, so I'd like to see this in as well. Just a few little
>> things:
> ok thanks,
>> Perhaps something like
>> #if DEFAULT_CONSOLE_LOGLEVEL < 8 //8 = debug level
>> inline void writeback(...)
>> {
>>     pci_write_config8(...);
>> }
>> #else
>> (original function)
>> #endif
> ok sounds good.
>  +
>>> +    /* TODO: if SATA is disabled, move IDE to fn0 to conform PCI
>>> specs */
>> I have a little piece of code to do this, I've just got to figure out
>> where/how to do it. Leave it as is and I'll take care of later.
> It is in "VT8237R Plus BIOS Porting Guide" just few lines of code, i
> can write it in next mail so NDA is "satisfied".

OK. Problem is though it has to be taken care of before the devices are
scanned, so that no device drops off or appears and confuses LB. If the
lpc bridge were scanned before the sata one, it could be done then, but
unfortunately it isn't. I've been doing it during ram init, but I
imagine it could be done somewhere shortly thereafter.

>> PCI_DEVICE_ID_VIA_VT8237R_LPC please. Datasheet refers to it as lpc, as
>> does the file name.
> Hmm i tried to stick the to the name common in LB and in in PCIID

IMO, it needs to remain consistent one way or another. I still vote for
LPC, since that is what the datasheet refers to it as and it's the main
function of the controller. ISA is a dying breed, it's only on there for
super io and sensor support. But either that or change the file name,
doesn't really matter.


More information about the coreboot mailing list