[LinuxBIOS] [PATCH] VIA VT8237R support
corey.osgood at gmail.com
Mon Oct 29 00:43:55 CET 2007
Rudolf Marek wrote:
>>> It is in "VT8237R Plus BIOS Porting Guide" just few lines of code, i
>>> can write it in next mail so NDA is "satisfied".
>> OK. Problem is though it has to be taken care of before the devices are
>> scanned, so that no device drops off or appears and confuses LB. If the
>> lpc bridge were scanned before the sata one, it could be done then, but
>> unfortunately it isn't. I've been doing it during ram init, but I
>> imagine it could be done somewhere shortly thereafter.
> Imho that function I placed the comment is called very very early, because it is
> static device??
I think I overlooked it, I'll have to check again.
>>>> PCI_DEVICE_ID_VIA_VT8237R_LPC please. Datasheet refers to it as lpc, as
>>>> does the file name.
>>> Hmm i tried to stick the to the name common in LB and in in PCIID
>> IMO, it needs to remain consistent one way or another. I still vote for
>> LPC, since that is what the datasheet refers to it as and it's the main
>> function of the controller. ISA is a dying breed, it's only on there for
>> super io and sensor support. But either that or change the file name,
>> doesn't really matter.
> Ok I will rename and respin somehow. Perhaps tomorrow?
You don't have to remake the patch, just edit it. Perhaps even the
committer can do it?
More information about the coreboot