[LinuxBIOS] [BUILDROM] Missing Serengeti-Cheetah file

Uwe Hermann uwe at hermann-uwe.de
Tue Oct 30 02:00:28 CET 2007


On Mon, Oct 29, 2007 at 04:08:33PM -0600, Jordan Crouse wrote:
> I missed a patch file when I added the S-C stuff to buildrom last week.
> THis just patches LB to use ../payload.elf as the target (an unfortunate
> v2 side effect).


> [BUILDROM] Missing Serengeti-Cheetah file 
> 
> This file should have gone with the rest of the patch - it patches LinuxBIOS
> to look for payload in ../
> 
> Signed-off-by: Jordan Crouse <jordan.crouse at amd.com>

Peter already ACKed, but here's one more:

Acked-by: Uwe Hermann <uwe at hermann-uwe.de>
 

> +@@ -29,7 +29,7 @@ romimage "normal"
> + #	payload ../../../payloads/tg3.zelf
> + #	payload ../../../../payloads/tg3_vga.zelf
> + #	payload ../../../../payloads/tg3--filo_hda2_vga.zelf
> +-	payload ../../../../payloads/tg3--filo_hda2_vga_5.4.1.zelf
> ++#	payload ../../../../payloads/tg3--filo_hda2_vga_5.4.1.zelf
> + #	payload ../../../../payloads/e1000_vga.zelf
> + #	payload ../../../../payloads/tg3--filo_hda2_vga_5_4.zelf
> + #	payload ../../../payloads/tg3_com2.zelf
> +@@ -38,6 +38,7 @@ romimage "normal"
> + #        payload ../../../payloads/tg3--eepro100--e1000--filo_hda2.zelf
> + #	payload ../../../payloads/tg3--eepro100--e1000--filo_hda2_5.3.zelf
> + #	payload ../../../payloads/tg3--eepro100--e1000--filo_hda2_com2.zelf
> ++	payload ../payload.elf
> + end
> + 
> + romimage "fallback" 
> +@@ -62,7 +63,7 @@ romimage "fallback" 
> + #	payload ../../../../payloads/filo_hda.zelf
> + #	payload ../../../../payloads/tg3--filo_hda2_vga.zelf
> + #	payload ../../../../payloads/tg3--filo_hda2_vga_5_4.zelf
> +-	payload ../../../../payloads/tg3--filo_hda2_vga_5.4.1.zelf
> ++#	payload ../../../../payloads/tg3--filo_hda2_vga_5.4.1.zelf
> + #	payload ../../../../payloads/filo_hda2_novga.zelf
> + #	payload ../../../payloads/tg3_com2.zelf
> + #       payload ../../../payloads/e1000--filo.zelf
> +@@ -70,6 +71,7 @@ romimage "fallback" 
> + #        payload ../../../payloads/tg3--eepro100--e1000--filo_hda2.zelf
> + #	payload ../../../payloads/tg3--eepro100--e1000--filo_hda2_5.3.zelf
> + #	payload ../../../payloads/tg3--eepro100--e1000--filo_hda2_com2.zelf
> ++	payload ../payload.elf

But why all of the commented stuff? It's absolutely not needed in
buildrom, so why not just drop it? The single line with payload.elf is
fully sufficient.


Uwe.
-- 
http://www.hermann-uwe.de  | http://www.holsham-traders.de
http://www.crazy-hacks.org | http://www.unmaintained-free-software.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20071030/2e68ad83/attachment.sig>


More information about the coreboot mailing list