[LinuxBIOS] [PATCH] Add support for the Asus A8V-E SE motherboard

Stefan Reinauer stepan at coresystems.de
Wed Oct 31 11:40:08 CET 2007


* Rudolf Marek <r.marek at assembler.cz> [071030 21:58]:
> > "LinuxBIOS" as string? How long can the ID become?
> 
> 6 bytes.
 
You could also use these defines from acpi.h:

#define OEM_ID                "LXBIOS"
#define ASLC                  "NONE"


> >> +	memcpy(header->oem_table_id, "LXBACPI ", 8);
> >> +	memcpy(header->asl_compiler_id, "LXB", 8);
> > 
> > Same here. How long?
> 
> 8 and 8, it is the last parameter.
 
Not so sure.

from acpi.h:
char asl_compiler_id [4];    /* ASL compiler vendor ID */\


one is wrong.. which one?


[..] regarding FADT [..]

> Yes perhaps. I used some example from other code.
 
We should move this information to the dts in v3.

> >> +void *smp_write_config_table(void *v)
> >> +{
> >> +        static const char sig[4] = "PCMP";
> > 
> > 
> >> +        static const char oem[8] = "LNXI    ";
> > 
> > Should be "ASUS    " probably, but I don't think that can break anything,
> > it's more a cosmetic issue AFAIK.
> 
> We are the BIOS oem ;)
 
Then make it LNXB. LNXI is Linux Networx, a former contributor or
LinuxBIOS.

> > Copyright (C) xxxx Stefan Reinauer <stepan at openbios.org>
> > Copyright (C) xxxx Nick Barker <nick.barker9 at btinternet.com>
> > 
> > then. I think this is not done in the original file either, and should
> > be fixed there, too. Listing all copyright owners explicitly is important.
> 
> What about xxxxx?
 
Just forget about this for now. It's a different issue and should not
block your code.

> >> +default HAVE_OPTION_TABLE=0
> > 
> > Make this 1. If the file is there already, why not use it?
 
> I need to have cmos valid for old award bios, I need the defaults from the
> option table. Even if I do not write to CMOS some bits are strange and confuses 
> linuxbios configuration. I will fix together with proper CMOS support.
 
I suggest making the "default" 1 and overriding it in the targets/
Config.lb with 0 to reflect that special configuration. Maybe with a
comment?

> >> +
> >> +	while (1) {
> >> +		/* daisy daisy ... */
> > 
> > ???
> http://en.wikipedia.org/wiki/Hal_9000
 
:-)) I love it.

Stefan

-- 
coresystems GmbH • Brahmsstr. 16 • D-79104 Freiburg i. Br.
      Tel.: +49 761 7668825 • Fax: +49 761 7664613
Email: info at coresystems.dehttp://www.coresystems.de/
Registergericht: Amtsgericht Freiburg • HRB 7656
Geschäftsführer: Stefan Reinauer • Ust-IdNr.: DE245674866




More information about the coreboot mailing list