[LinuxBIOS] [PATCH] v3: code documentation fixes

Stefan Reinauer stepan at coresystems.de
Sun Sep 2 18:43:05 CEST 2007


* Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net> [070830 02:05]:
> -		printk(BIOS_SPEW, "%s: %s(%s) have_resources %d enabled %d\n",
> +		printk(BIOS_SPEW,
> +		       "%s: %s(%s) dtsname %s have_resources %d enabled %d\n",
>  		       __func__, bus->dev->dtsname, dev_path(bus->dev),

These kind of indent changes look rather ugly in my opinion.

> +	/* TODO: Explain why we use printk here although it is impossible */

What? Impossible? Why? That commend looks pretty bogus.

>  	printk(BIOS_NOTICE, console_test);
>  
>  	dev_init();
> 
> 
> 
> -- 
> linuxbios mailing list
> linuxbios at linuxbios.org
> http://www.linuxbios.org/mailman/listinfo/linuxbios
> 

-- 
coresystems GmbH • Brahmsstr. 16 • D-79104 Freiburg i. Br.
      Tel.: +49 761 7668825 • Fax: +49 761 7664613
Email: info at coresystems.dehttp://www.coresystems.de/
Registergericht: Amtsgericht Freiburg • HRB 7656
Geschäftsführer: Stefan Reinauer • Ust-IdNr.: DE245674866




More information about the coreboot mailing list