[LinuxBIOS] [PATCH] LAR no-segment crash (was: Re: r2758 - in trunk: LinuxBIOSv2/util util)

ron minnich rminnich at gmail.com
Wed Sep 5 05:21:28 CEST 2007


On 9/4/07, Alex Beregszaszi <alex at rtfs.hu> wrote:

> > The current code's lar handling is pretty much broken even though that
> > code was reviewed, but obviously nobody even tested it:

I did test it before each commit, with a full rebuild. This is a case
where testing can miss a bug.

(Alex, I know you did not write that, I lost track who wrote it).


> > also the current code contains quite some warnings again regarding
> > int-to-pointer casts in lar.c and pointer-to-int cast and uninitialized
> > variable use in stage1.c

let's fix it.

ron




More information about the coreboot mailing list