[LinuxBIOS] PATCH: add the pcengines ALIX1

[Uwe Hermann]

On Sat, Sep 08, 2007 at 10:12:11PM -0700, ron minnich wrote:
> Partial diff attached, .... here are comments.
> 
> Still builds.

Yep, look good. Committed in r2766 with some minor cosmetics.

Shall we list the board in the wiki as "WIP" (as it doesn't boot Linux yet)?


> > NACK, see above. This is common code just about every board duplicateѕ
> > again and again. I have a patch which adds a global failover.c into
> > lib/ (which my recent i810 board patch already uses, btw).
> >
> > I'll post the patch ASAP.
> 
> I'll wait for your failover.c patch, but beware: they are not ALWAYS
> totally identical.

Yes, unfortunately, but I think 90% or so are the same. Maybe we can
even make failover.c generic enough for 100% of the boards?

Anyway, my failover.c patch is posted, please review.


> > Only checks _some_ memory.
> 
> :-)
> 
> Will fix in next go round, I forgot to.

I fixed it while I was at it.

 
> > > +
> > > +      We use method 1 on Norwich and on this board too.
> > > +     */
> >
> > This comment is in some other file, too. Maybe it should go in the wiki
> > or in the generic CAR code somewhere? No need to duplicate it in every
> > LX board...
> 
> I want this comment in, since not all users of LX read all files that use LX ;-)

Well, yeah, but I think we should still put it somewhere globally and
then just "link" to it from here a la "for details see XXXX"...


Uwe.
-- 
http://www.hermann-uwe.de  | http://www.holsham-traders.de
http://www.crazy-hacks.org | http://www.unmaintained-free-software.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20070909/b1636acf/attachment.sig>