[LinuxBIOS] [PATCH] Flashrom: sis630 simplification

Stefan Reinauer stepan at coresystems.de
Tue Sep 11 11:53:58 CEST 2007

* Li-Ta Lo <ollie at lanl.gov> [070910 19:24]:
> > I'm not too eager to find out the hard way. This is low-level
> > enough that I think there _might_ be unintended/unnoticed consequences.
> > 
> > Anybody with such a chipset willing to test the patch?
> It was too long ago for me to remember why I was doing something like 
> that. My guess is that the pci_dev passed to the function is the 
> northbridge but you have to program the southbridge or the LPC or it
> was not linked with pci_util then.

Not linking against libpci was indeed the issue that caused this. 
I think we should check the code in like that. 


coresystems GmbH • Brahmsstr. 16 • D-79104 Freiburg i. Br.
      Tel.: +49 761 7668825 • Fax: +49 761 7664613
Email: info at coresystems.dehttp://www.coresystems.de/

More information about the coreboot mailing list