[LinuxBIOS] r496 - in LinuxBIOSv3: include lib

Uwe Hermann uwe at hermann-uwe.de
Sun Sep 23 20:04:44 CEST 2007

On Sun, Sep 23, 2007 at 02:55:24PM +0200, Carl-Daniel Hailfinger wrote:
> > +static inline int strncmp(const char *s1, const char *s2, int maxlen)
> Do we really want the "inline" keyword? Once we have more than one user,
> it is a waste of text size and with only one user AFAIK gcc inlines it
> automatically.

Yep, I think we can drop 'inline' in almost all cases in the whole code base.

With string.h I also think we should make it string.c and put the
prototypes in a header. I don't like code in header files at all.

http://www.hermann-uwe.de  | http://www.holsham-traders.de
http://www.crazy-hacks.org | http://www.unmaintained-free-software.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20070923/32e2cd60/attachment.sig>

More information about the coreboot mailing list