[coreboot] stage0_i586.S Try 2

Carl-Daniel Hailfinger c-d.hailfinger.devel.2006 at gmx.net
Fri Apr 4 22:46:34 CEST 2008


On 04.04.2008 22:15, Stefan Reinauer wrote:
> Signed-off-by: Stefan Reinauer <stepan at coresystems.de>

Could you try this whitespace-only change instead?

Preliminary version...

Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net>

Index: arch/x86/stage0_i586.S
===================================================================
--- arch/x86/stage0_i586.S	(Revision 654)
+++ arch/x86/stage0_i586.S	(Arbeitskopie)
@@ -319,14 +319,13 @@
  * windowoffset is the 32k-aligned window into CAR size
  */
 .macro simplemask carsize, windowoffset
-	.set gas_bug_workaround,(((\carsize - \windowoffset) / 0x1000) - 4)
+	.set gas_bug_workaround,(((\carsize-\windowoffset)/0x1000)-4)
 	extractmask gas_bug_workaround, %eax
-	.set gas_bug_workaround,(((\carsize - \windowoffset) / 0x1000))
+	.set gas_bug_workaround,(((\carsize-\windowoffset)/0x1000))
 	extractmask gas_bug_workaround, %edx
-/* Without the gas bug workaround, the entire macro would consist only of the
- * two lines below.
-	extractmask (((\carsize - \windowoffset) / 0x1000) - 4), %eax
-	extractmask (((\carsize - \windowoffset) / 0x1000)), %edx
+/* DO NOT CHANGE THE FORMATTING of the two lines below! It will break GNU as.
+	extractmask (((\carsize-\windowoffset)/0x1000)-4), %eax
+	extractmask (((\carsize-\windowoffset)/0x1000)), %edx
  */
 .endm
 






More information about the coreboot mailing list