[coreboot] nrv2b cleanup patch (again)

Stefan Reinauer stepan at coresystems.de
Sat Apr 12 09:31:30 CEST 2008

Myles Watson wrote:
> This very short patch fixes nrv2b compression in lar.
> It also fixes lzma compression in lar to fix the silent memory
> corruption that was possible when files didn't compress well.
> It adds some comments to both files and the file that calls them.
> Myles
> Signed-off-by: Myles Watson <mylesgw at gmail.com>
Acked-by: Stefan Reinauer <stepan at coresystems.de>

> -	std::memcpy(out, &result[0], *out_len);
> +	if (*out_len < in_len)
> +		std::memcpy(out, &result[0], *out_len);
I think this one should even be memcpy instead of std:memcpy.. I had 
some versions of gcc complain that memcpy is not in the std scope.

Not really part of this patch, but I saw later down you use memcpy 
without std:: anyways.


coresystems GmbH • Brahmsstr. 16 • D-79104 Freiburg i. Br.
      Tel.: +49 761 7668825 • Fax: +49 761 7664613
Email: info at coresystems.dehttp://www.coresystems.de/
Registergericht: Amtsgericht Freiburg • HRB 7656
Geschäftsführer: Stefan Reinauer • Ust-IdNr.: DE245674866

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 249 bytes
Desc: OpenPGP digital signature
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20080412/a71fab42/attachment.sig>

More information about the coreboot mailing list