[coreboot] [PATCH] [v3] add pcengines alix.2c3
marc.jones at amd.com
Thu Apr 17 19:13:58 CEST 2008
Carl-Daniel Hailfinger wrote:
> On 10.04.2008 03:14, Ward Vandewege wrote:
>> Another product of the Denver summit. Thanks to the expert guidance of Ron,
>> Marc, Jordan and Stepan as well as the quality of the alix.1c v3 code, this
>> was probably the easiest port ever.
>> This patch is largely a copy-and-past from the alix.1c board, with some
>> tweaks (no superio, and the irqs are routed a bit differently).
>> One outstanding issue still - the usb ports fight over an interrupt with
>> eth2. Hopefully that will get fixed soon.
>> Tested on real hardware.
> Great work!
> I'd like to see two "changes" before you commit, though:
> - Use svn cp wherever possible. That helps to document the ancestry of
> the code.
> - Remove the unwanted_vpci stuff for now. I want to review that code
> separately in depth and holding up alix.2c3 because of pending
> unwanted_vpci reviews would be bad.
> Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net>
Since the vpci patches have been acked, I think that this is ready to go.
Acked-by: Marc Jones <marc.jones at amd.com>
Senior Firmware Engineer
(970) 226-9684 Office
mailto:Marc.Jones at amd.com
More information about the coreboot