[coreboot] buildrom bug

Jordan Crouse jordan.crouse at amd.com
Thu Apr 24 16:38:26 CEST 2008


On 24/04/08 09:54 -0400, Ward Vandewege wrote:
> On Thu, Apr 24, 2008 at 12:54:20PM +0200, Peter Stuge wrote:
> > On Thu, Apr 24, 2008 at 11:21:41AM +0200, Uwe Hermann wrote:
> > > On Thu, Apr 24, 2008 at 06:32:17AM +0200, Peter Stuge wrote:
> > > > I configured v2 and TINT, then:
> > > 
> > > Cannot reproduce using ALIX.1C target in buildrom.
> > 
> > Maybe you have ruby installed.
> > 
> > 
> > > Which target did you use?
> > 
> > I thought I picked 1C but it seems I was using DB800.
> > 
> > 
> > > Do you have some .config* .tmpconfig* .kconfig* files around?
> > > Try a fresh checkout, just in case.
> > 
> > It was a fresh checkout. Am retrying.
> > 
> > 
> > > > $ make
> > > > /home/stuge/co/buildrom/buildrom-devel/packages/grub2/grub2.mk:28:
> > > > *** To build GRUB2, you need to install 'ruby'.  Stop.
> > 
> > Still the same.
> 
> 
> It's a bug. This is a workaround (I'm still working on a proper fix, 
> make should not include all payload makefiles all the time):

Thanks - I ack this if we need to, but ++ on fixing the includes
properly.

> -------------------------------------
> Index: packages/grub2/grub2.mk
> ===================================================================
> --- packages/grub2/grub2.mk     (revision 155)
> +++ packages/grub2/grub2.mk     (working copy)
> @@ -24,9 +24,11 @@
>  
>  HAVE_RUBY:=$(call find-tool,ruby)
>  
> +ifeq ($(PAYLOAD),grub2)
>  ifeq ($(HAVE_RUBY),n)
>  $(error To build GRUB2, you need to install 'ruby')
>  endif
> +endif
>  
>  $(SOURCE_DIR)/$(GRUB2_TAR):
>         @ mkdir -p $(SOURCE_DIR)
> -------------------------------------
> 
> Thanks,
> Ward.
> 
> -- 
> Ward Vandewege <ward at fsf.org>
> Free Software Foundation - Senior System Administrator
> 
> -- 
> coreboot mailing list
> coreboot at coreboot.org
> http://www.coreboot.org/mailman/listinfo/coreboot
> 

-- 
Jordan Crouse
Systems Software Development Engineer 
Advanced Micro Devices, Inc.





More information about the coreboot mailing list