[coreboot] [PATCH] [buildrom] more 'make clean' fixes

Myles Watson mylesgw at gmail.com
Fri Apr 25 18:49:29 CEST 2008

> -----Original Message-----
> From: Ward Vandewege [mailto:ward at gnu.org]
> Sent: Friday, April 25, 2008 10:08 AM
> To: Myles Watson
> Cc: 'Coreboot'
> Subject: [PATCH] [buildrom] more 'make clean' fixes
> On Fri, Apr 25, 2008 at 09:16:51AM -0600, Myles Watson wrote:
> > I thought make was broken because make clean was broken, but I could be
> > wrong.  I have more trouble when I use make clean then when I just run
> make
> > again.
> OK. What do you think of the attached patch?

I like it.  Could you add coreinfo's .copied and kernel's .header?

With that change:
Acked-by: Myles Watson <mylesgw at gmail.com>

Maybe we should remove the .unpacked stamp on a make distclean too?

> > > Should we automatically do a 'make clean' as part of every 'make'
> call?
> >
> > I'd hate to do that.  When I'm testing the tyan boards I don't want to
> make
> > the kernel every time.  Make clean removes the entire deploy directory.
> Yeah. You're right.
> > Another problem we have is that we never check to see if
> > deploy/$(PAYLOAD)-payload.elf is old.  This leads to some unexpected
> > behavior for me.

This may have been a side effect of something else.  I'll check it again
after we get some of these patches in.


More information about the coreboot mailing list