[coreboot] buildrom bug

[Jordan Crouse]

On 25/04/08 10:13 -0600, Myles Watson wrote:
> 
> 
> > -----Original Message-----
> > From: coreboot-bounces at coreboot.org [mailto:coreboot-bounces at coreboot.org]
> > On Behalf Of Jordan Crouse
> > Sent: Friday, April 25, 2008 9:40 AM
> > To: Myles Watson; coreboot at coreboot.org
> > Subject: Re: [coreboot] buildrom bug
> > 
> > On 25/04/08 11:37 -0400, Ward Vandewege wrote:
> > > On Fri, Apr 25, 2008 at 09:20:23AM -0600, Myles Watson wrote:
> > > > > Don't we need that PAYLOAD_AND_DEP_MK change for every payload?
> > > >
> > > > Did I miss one?  Most of the payloads don't have dependencies.  The
> > > > libpayload ones were the only ones I saw.
> > >
> > > The LAB and kernel payloads?
> > >
> > > > > +include $(PACKAGE_DIR)/utils/nrv2b.mk
> > > >
> > > > Yep, I missed that one.  Fixed.
> > >
> > > Great.
> > >
> > > > > This also brings up the question why nrv2b.mk is in the 'utils'
> > directory,
> > > > > instead of the $(PACKAGE_DIR)/nrv2b/ directory?
> > > >
> > > > Because it doesn't get included in the ROM?
> > >
> > > Hmm, ok, yes.
> > 
> > I guess it all depends on how many directories we want to look at,
> > and trade that off with how complex the scripts should be.  I don't
> > really have an opinion one way or the other on that.
> 
> I'm happy to move it.  I was just speculating on the original reason it was
> there.  Unfortunately, lzma is in $(PACKAGE_DIR)/lzma/, which shoots down my
> theory.  I think that we should avoid automagically including make files.
> There are few enough of them that we should only include specific ones to
> avoid problems.

Your mistake is that you assumed that we (I) followed any specific plan. :)

Yes, go ahead and move them where ever you think they work the best,
and ack on the including make files comment.

Jordan

-- 
Jordan Crouse
Systems Software Development Engineer 
Advanced Micro Devices, Inc.