[coreboot] buildrom bug
mylesgw at gmail.com
Mon Apr 28 21:35:17 CEST 2008
> -----Original Message-----
> From: Jordan Crouse [mailto:jordan.crouse at amd.com]
> Sent: Monday, April 28, 2008 1:15 PM
> To: Myles Watson
> Cc: coreboot at coreboot.org
> Subject: Re: buildrom bug
> On 28/04/08 13:08 -0600, Myles Watson wrote:
> > > -----Original Message-----
> > > From: Jordan Crouse [mailto:jordan.crouse at amd.com]
> > > Sent: Friday, April 25, 2008 3:53 PM
> > > To: Myles Watson
> > > Cc: coreboot at coreboot.org
> > > Subject: Re: buildrom bug
> > >
> > > On 25/04/08 12:15 -0600, Myles Watson wrote:
> > > > I agree. Do you want to create the patch or send me a patch against
> > > mine?
> > >
> > > Okay - so here we go. This patch uses black make magic to construct
> > > the list of .mk files to be included. But wait, thats not all - it
> > > consolidates all of the platform specific coreboot .mk and kernel .mk
> > > includes into generic toplevel packages/coreboot-v2/coreboot-v2.mk and
> > > packages/kernel/kernel.mk files so that we don't have to specially
> > > files from within the toplevel Makefile. Finally, to avoid
> > > including roms.mk and geodevsa.mk, I revamped how geodevsa works. I'm
> > > super happy with it, but its at least reasonable and gets rid of some
> > > ifdefs. We'll need to address this in more detail when we revamp the
> > > lar UI and have other platforms that need option ROMs.
> > >
> > > Please test and report back - this isn't a really scary patch, but it
> > > touches
> > > lots of files and lots of platforms.
> > Jordan,
> > Could you send it again from the latest version? Sorry for the mix up.
> It should apply against the latest version, I did the nrv2b.mk fixup
> locally in my tree.
I was actually talking about the simplify-v2 patch. For example, there is
no more tyan-generic.mk or tyan-s2891.mk.
More information about the coreboot