[coreboot] Fwd: DBE62 v3 strangeness since v3 rev 649
c-d.hailfinger.devel.2006 at gmx.net
Tue Apr 29 13:50:06 CEST 2008
On 29.04.2008 05:55, ron minnich wrote:
> If somebody could ack this I can close out the recent dbe62 problems.
Sure, but see below.
> ---------- Forwarded message ----------
> From: ron minnich <rminnich at gmail.com>
> Date: Fri, Apr 18, 2008 at 10:09 PM
> Subject: Re: DBE62 v3 strangeness since v3 rev 649
> To: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net>
> Cc: Coreboot <coreboot at coreboot.org>
> On Tue, Apr 15, 2008 at 2:52 PM, Carl-Daniel Hailfinger
> <c-d.hailfinger.devel.2006 at gmx.net> wrote:
>> Hi Ron,
> > this one is for you: Your commit 649 had a few probably unintended side
> > effects:
> > - set_delay_control thinks zero DIMMs are installed because
> > SPD_PRIMARY_SDRAM_WIDTH does not exist in the SPD table.
> > - Due to that, the GLCP_DELAY_CONTROLS msr is set to 0.
> > Please confirm that you really wanted these settings.
> This mistake arose out of my attempt to clean up the namings of things
> in the original initram. It had names from two sources.
> This patch cleans up that error, and is my attempt at cleaning up the
> null pointer
> issue in device/device.c, which I actually don't understand.
That's the big problem. I have no idea whether it is allowed to have
bus->dev==NULL at that point in time. If it is not allowed, we should
add a big fat warning. If it is allowed, your fix is absolutely correct.
> This patch allows me to almost boot a Plan 9 kernel from flash.
Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net>
More information about the coreboot