[coreboot] patch: k8 support in v3.

Marc Jones Marc.Jones at amd.com
Fri Aug 1 18:50:28 CEST 2008


ron minnich wrote:
...

> OK, this is it, beginnings of K8 support 
> 
> and some geode cleanup. 
> 
> 1. fix some includes on geode. 
> Index: arch/x86/geodelx/stage1.c
> Index: southbridge/amd/cs5536/stage1.c
> 2. add amd_k8.h include. 
> 
Seperate out the geode stuff. I think you can selfack it. They are 
trivial IMO. Here's an ack for the geode stuff anyway.

Acked-by: Marc Jones <marc.jones at amd.com>




> Index: arch/x86/Makefile
> Add K8 clauses
> Index: arch/x86/mtrr.h
> Index: include/arch/x86/amd_k8.h
> mv this to include, it is needed in several places now. 
> 
> K8 files: 
> Index: arch/x86/amdk8/stage1.c
> Index: arch/x86/amd/stage0.S
> Index: arch/x86/Kconfig
> Index: mainboard/gigabyte/m57sli/Makefile
> Index: mainboard/gigabyte/m57sli/dts
> Index: mainboard/gigabyte/m57sli/stage1.c
> Index: mainboard/gigabyte/m57sli/initram.c
> Index: mainboard/gigabyte/m57sli/Kconfig
> Index: mainboard/Kconfig
> 
> 
> The m57sli almost builds. It's pretty empty. The dtc is not run .
> 
> Signed-off-by: Ronald G. Minnich <rminnich at gmail.com>
> 

...

> -#endif				/* ARCH_X86_MTRR_H */
> Index: arch/x86/Makefile
> ===================================================================
> --- arch/x86/Makefile	(revision 699)
> +++ arch/x86/Makefile	(working copy)
> @@ -124,9 +124,12 @@
>  	STAGE0_ARCH_X86_OBJ += geodelx/stage1.o
>  	STAGE0_ARCH_X86_OBJ += ../../northbridge/amd/geodelx/geodelxinit.o
>  else
> -	STAGE0_CAR_OBJ = stage0_i586.o
> +ifeq ($(CONFIG_CPU_AMD_K8),y)
> +	STAGE0_CAR_OBJ = amd/stage0.o
> +	STAGE0_ARCH_X86_OBJ += amdk8/stage1.o
>  endif
>  endif
> +endif

Add else and put the stage0_i586 on the end?

I agree with getting the pieces in place as we go.
The files looked fine to me but I didn't try to build it.....

Acked-by: Marc Jones <marc.jones at amd.com>




-- 
Marc Jones
Senior Firmware Engineer
(970) 226-9684 Office
mailto:Marc.Jones at amd.com
http://www.amd.com/embeddedprocessors





More information about the coreboot mailing list