[coreboot] v3 : mcp55.c patch

Uwe Hermann uwe at hermann-uwe.de
Sun Aug 3 19:03:13 CEST 2008


On Sat, Aug 02, 2008 at 02:04:51PM -0700, ron minnich wrote:
> Index: southbridge/nvidia/mcp55/stage1.c
> ===================================================================
> --- southbridge/nvidia/mcp55/stage1.c	(revision 713)
> +++ southbridge/nvidia/mcp55/stage1.c	(working copy)
> @@ -19,6 +19,17 @@
>   * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301 USA
>   */
>  
> +#include <console.h>
> +#include <io.h>
> +#include <device/device.h>
> +#include <device/pci.h>


> +#include <device/pci_ids.h>
> +#include <device/pci_ops.h>

These two are not needed, pci.h already includes them.


> -static uint32_t final_reg;
> +static u32 final_reg;

Is the static really needed or a romcc artifact?

  
Uwe.
-- 
http://www.hermann-uwe.de  | http://www.holsham-traders.de
http://www.crazy-hacks.org | http://www.unmaintained-free-software.org




More information about the coreboot mailing list