[coreboot] patch: k8north more fixes etc. for compilation

Carl-Daniel Hailfinger c-d.hailfinger.devel.2006 at gmx.net
Mon Aug 4 00:57:10 CEST 2008


On 04.08.2008 00:43, ron minnich wrote:
> On Sun, Aug 3, 2008 at 3:36 PM, Carl-Daniel Hailfinger
> <c-d.hailfinger.devel.2006 at gmx.net> wrote:
>   
>> On 04.08.2008 00:18, ron minnich wrote:
>>     
>>> This is much closer to compiling.
>>> Need to get spd in.
>>> now use the new options stuff from LAR.
>>> Added correct defines for nvidia.
>>> mv macros.h to include/arch/x86
>>> Other basic cleanup to get things to build.
>>>
>>> Still need to resolve the struct device thing. Probably going to write a
>>> small function that takes bus, dev, fn and creates an un-connected struct device
>>> for stage 1 use only. This will get us there; we need to get working, then we
>>> can see the beautician.
>>>
>>> Signed-off-by: Ronald G. Minnich <rminnich at gmail.com>
>>>       
>> Same comment as before: Ugly base code, but the patch improves the
>> situation.
>>
>> Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net>
>>     
>
> I have no argument with your comments here. We'll fix it! ;-)
>   

I'm confident we will.

> Committed revision 717.
>   

You forgot to svn add macros.h at the new location (or use svn mv in the
first place).

Regards,
Carl-Daniel

-- 
http://www.hailfinger.org/





More information about the coreboot mailing list