[coreboot] patch: resource map proposal.
Peter Stuge
peter at stuge.se
Mon Aug 4 19:56:03 CEST 2008
On Mon, Aug 04, 2008 at 07:50:32PM +0200, Carl-Daniel Hailfinger wrote:
> > a patch to apply on top of Ron's commit.
>
> If I'm successful, I'll be undoing 50% of Ron's patch.
That doesn't matter. This is early work in progress.
Key word: progress
> - pci_write_config32(a, b, c);
> + pci_cf8_conf1.write32(NULL, 0, a, b, c);
>
> Can't we just use a macro for that stuff?
> #define PCI_WRITE_CONFIG32_EARLY(a,b,c) pci_cf8_conf1.write32(NULL, 0, a, b, c);
Sorry, I don't see the point. I expect pci_cf8_* to change at least
once anyway. I think time is better spent elsewhere.
//Peter
More information about the coreboot
mailing list