[coreboot] patch: resource map proposal.

[Stefan Reinauer]

ron minnich wrote:
> On Mon, Aug 4, 2008 at 1:40 PM, Stefan Reinauer <stepan at coresystems.de> wrote:
>
>   
>> The obvious question: Do we need to use device_t as an input to that
>> function at all? Why don't we instead use simple pci functions taking a u32
>> as an input? We're a bios, after all, not an OS. Are we?
>>     
>
> That's a fine question. The convention could be that we call those
> functions as follows:
> blahblah(device->bus, device->devfn, etc. etc. )
>   

pci_read_config32(PCI_DEV(0,0x1f,0), reg); ?

Maps to about 5 assembler instructions.
> works for me. But let's revisit it later.
>
> I am fine with overloading but only in languages that really allow it ;-)
Overloading? I'm talking about simplifying, not inventing an OS ;-)


-- 
coresystems GmbH • Brahmsstr. 16 • D-79104 Freiburg i. Br.
      Tel.: +49 761 7668825 • Fax: +49 761 7664613
Email: info at coresystems.de  • http://www.coresystems.de/
Registergericht: Amtsgericht Freiburg • HRB 7656
Geschäftsführer: Stefan Reinauer • Ust-IdNr.: DE245674866


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 249 bytes
Desc: OpenPGP digital signature
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20080804/f8236f9b/attachment.sig>