[coreboot] coreinfo: Make hard-coded strings configurable for Bayou use

Jordan Crouse jordan.crouse at amd.com
Tue Aug 5 16:05:30 CEST 2008


On 05/08/08 14:57 +0200, Uwe Hermann wrote:
> See patch.
> 
> 
> Uwe.
> -- 
> http://www.hermann-uwe.de  | http://www.holsham-traders.de
> http://www.crazy-hacks.org | http://www.unmaintained-free-software.org

> Move out some hardcoded strings in coreinfo to become Kconfig variables.
> This is useful for use with (e.g.) Bayou in order let the user customize the
> payload name, description, version, etc.
> 
> For instance, instead of using stock coreinfo and calling the payload
> "coreinfo" and the Bayou menu item "Show system information" a user might
> only be interested in an NVRAM dump payload. Thus, he/she can enable
> only the NVRAM coreinfo module via Kconfig, and tell Kconfig to call
> the payload "NVRAMdumper" and the Bayou menu item "Show NVRAM contents".
> 
> This is build-tested, and tested against Bayou in QEMU.
> 
> Signed-off-by: Uwe Hermann <uwe at hermann-uwe.de>

Only one question - what about internationalization?  It doesn't seem
fair that English gets the default and everybody else has to change 
the kconfig.

Otherwise...

Acked-by: Jordan Crouse <jordan.crouse at amd.com>

-- 
Jordan Crouse
Systems Software Development Engineer 
Advanced Micro Devices, Inc.





More information about the coreboot mailing list