[coreboot] [PATCH] v3: move to anonymous unions
Stefan Reinauer
stepan at coresystems.de
Sun Aug 10 11:21:57 CEST 2008
Carl-Daniel Hailfinger wrote:
> On 04.08.2008 00:19, ron minnich wrote:
>
>> I like the change but please, NOBODY ack this until you test it on
>> something! this is a far-reaching change.
>>
>>
>
> Indeed. Did you find time to test it?
> Inline and attached is the updated patch against svn HEAD for your
> convenience.
>
> Regards,
> Carl-Daniel
>
> The named unions in the device tree code are obnoxious and degrade
> readability. Move to anonymous unions.
>
> Build tested on all targets. Boot tested on qemu.
>
> Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net>
Please prepare the same patch for v2, too. We should not have the device
tree code diverge too much before v3 actually becomes usable.
--
coresystems GmbH • Brahmsstr. 16 • D-79104 Freiburg i. Br.
Tel.: +49 761 7668825 • Fax: +49 761 7664613
Email: info at coresystems.de • http://www.coresystems.de/
Registergericht: Amtsgericht Freiburg • HRB 7656
Geschäftsführer: Stefan Reinauer • Ust-IdNr.: DE245674866
More information about the coreboot
mailing list