[coreboot] [PATCH] v3: move to anonymous unions

Carl-Daniel Hailfinger c-d.hailfinger.devel.2006 at gmx.net
Sun Aug 10 13:43:47 CEST 2008

On 10.08.2008 11:21, Stefan Reinauer wrote:
> Carl-Daniel Hailfinger wrote:
>> On 04.08.2008 00:19, ron minnich wrote:
>>> I like the change but please, NOBODY ack this until you test it on
>>> something! this is a far-reaching change.
>> Indeed. Did you find time to test it?
>> Inline and attached is the updated patch against svn HEAD for your
>> convenience.
>> Regards,
>> Carl-Daniel
>> The named unions in the device tree code are obnoxious and degrade
>> readability. Move to anonymous unions.
>> Build tested on all targets. Boot tested on qemu.
>> Signed-off-by: Carl-Daniel Hailfinger
>> <c-d.hailfinger.devel.2006 at gmx.net>
> Please prepare the same patch for v2, too. We should not have the
> device tree code diverge too much before v3 actually becomes usable.

Sure. But please spare me the task of running abuild for the v2 patch. I
simply don't have enough CPU power for that.

I have no idea whether ROMCC can handle anonymous unions, though, so
there might be unwanted side effects. And older gcc versions which are
usable with v2 might be broken by that change.
And then there's the question of whether we want to commit Ron's v3
device tree/pci changes to v2 as well. While I think they were really
great for v3 and I appreciate them, I'd like to be conservative
regarding v2 changes.

Thoughts? Still think the anonymous union stuff is v2 material?



More information about the coreboot mailing list