[coreboot] [PATCH] v3: fix Kconfig dependencies, update defconfigs

Stefan Reinauer stepan at coresystems.de
Mon Aug 18 19:02:41 CEST 2008


Carl-Daniel Hailfinger wrote:
> On 18.08.2008 18:57, Stefan Reinauer wrote:
>   
>> ron minnich wrote:
>>   
>>     
>>> On Mon, Aug 18, 2008 at 9:48 AM, Carl-Daniel Hailfinger
>>> <c-d.hailfinger.devel.2006 at gmx.net> wrote:
>>>
>>>
>>>   
>>>     
>>>       
>>>> It seems the K8 code is using CONFIG_LOGICAL_CPUS for that.
>>>>     
>>>>       
>>>>         
>>> I think the config logical cpus is for multicore. The name is
>>> confusing and I intend to change it.
>>>
>>>
>>>   
>>>     
>>>       
>>>> CONFIG_SMP does only control spinlocks and enables the LAPIC
>>>> unconditionally.
>>>>
>>>>     
>>>>       
>>>>         
>>>>>> - Should CONFIG_IOAPIC be selectable on GeodeLX and Qemu? Maybe for Qemu.
>>>>>>
>>>>>>         
>>>>>>           
>>>>>>             
>>>>> not sure on LX but it is unlikely?
>>>>>
>>>>>       
>>>>>         
>>>>>           
>>>> Jordan says the LX doesn't support it.
>>>>
>>>>     
>>>>       
>>>>         
>>> so the option should not be available.
>>>   
>>>     
>>>       
>> Those options are part of the hardware description, not real user
>> options. They're there only because of short comings of our current dts
>> scheme.
>>   
>>     
>
> If they are not user options, they shouldn't be selectable at all.
>   

Not in the user interface. Indeed.

And, correctly, they were not selectable by the user.

Please, guys, don't fix stuff that ain't broken.


-- 
coresystems GmbH • Brahmsstr. 16 • D-79104 Freiburg i. Br.
      Tel.: +49 761 7668825 • Fax: +49 761 7664613
Email: info at coresystems.dehttp://www.coresystems.de/
Registergericht: Amtsgericht Freiburg • HRB 7656
Geschäftsführer: Stefan Reinauer • Ust-IdNr.: DE245674866





More information about the coreboot mailing list