[coreboot] [PATCH] v3: use inb instead of outb for delays

Carl-Daniel Hailfinger c-d.hailfinger.devel.2006 at gmx.net
Fri Aug 22 03:34:32 CEST 2008


Use inb instead of outb for delays. v2 has already been converted in
r3509 which was
Signed-off-by: Stefan Reinauer <stepan at coresystems.de>
Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net>

I'm tempted to do the same here, but with signoff and ack switched.

Index: corebootv3-stuff3/arch/x86/udelay_io.c
===================================================================
--- corebootv3-stuff3/arch/x86/udelay_io.c	(Revision 798)
+++ corebootv3-stuff3/arch/x86/udelay_io.c	(Arbeitskopie)
@@ -23,6 +23,7 @@
 void udelay(unsigned int usecs)
 {
 	unsigned int i;
+	/* let's hope this is not optimized out */
 	for (i = 0; i < usecs; i++)
-		outb(i & 0xff, 0x80);
+		(void) inb(0x80);
 }


-- 
http://www.hailfinger.org/





More information about the coreboot mailing list