[coreboot] [PATCH] Inefficient test in buildtarget script

Mats Erik Andersson mats.andersson at gisladisker.se
Wed Aug 27 14:23:56 CEST 2008

Capture output from  'ld --help', in order that the test
becomes meaningful. The linker puts help texts on stderr.

Signed-off-by: Mats Erik Andersson <mats.andersson at gisladisker.se>

Index: targets/buildtarget
--- targets/buildtarget	(revision 3531)
+++ targets/buildtarget	(arbetskopia)
@@ -69,7 +69,7 @@
 rm -rf .$$.tmp
-if $CC -Wl,--help | grep -q build-id; then
+if $CC -Wl,--help 2>&1 | grep -q build-id; then
 	EXTRA_LFLAGS="$EXTRA_LFLAGS -Wl,--build-id=none"

More information about the coreboot mailing list