[coreboot] [PATCH] LAR: Don't clobber top 8 bytes

Carl-Daniel Hailfinger c-d.hailfinger.devel.2006 at gmx.net
Wed Dec 3 18:49:10 CET 2008

On 03.12.2008 12:48, Stefan Reinauer wrote:
> Carl-Daniel Hailfinger wrote:
>> LAR currently overwrites the top 13 bytes (0xfffff3-0xffffff) of the
>> bootblock with zeros, then it stores the ROM size in 0xfffff4-0xfffff7.
>> The top 8 bytes are unused in that scheme.
>> Leave the top 8 bytes as they are and allow us to store something in
>> there during the bootblock build process. The byte at 0xfffff3 is 0xff
>> by default on x86 and setting it to 0 is not needed.
>> Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net>
> Nack.
> They're unused, and until they are used, they should be cleared to a
> consistent state.

They are already cleared by arch/x86/stage0_common.S. Having to clear
them in the LAR would mean the code in stage0_common.S is crap and needs
to be fixed.



More information about the coreboot mailing list