[coreboot] [PATCH] flashrom patch for partial flash read #2

Peter Stuge peter at stuge.se
Thu Dec 4 05:39:39 CET 2008


Stephan GUILLOUX wrote:
> >>+static int read_flash(struct flashchip *flash, uint8_t *buf, uint32_t 
> >>offset, uint32_t length)
> >>+{
> >>+	int total_size = flash->total_size * 1024;
> >
> >total_size should be unsigned.
> 
> Agreed, but found some inconsistencies for total_size :

I disagree, this does not matter at all right now, and will not for
some time to come. Worry about it later.


//Peter




More information about the coreboot mailing list