[coreboot] [PATCH] flashrom: Group probe function together with associated IDs

Stefan Reinauer stepan at coresystems.de
Tue Dec 9 09:14:36 CET 2008

Carl-Daniel Hailfinger wrote:
> The flash probe function and the IDs for that specific probe function
> belong together. Group them together on a single line.
> We already have chips with multiple probe functions and multiple IDs.
> This patch is the first step in consolidating the present way of
> creating a new chip definition for each ID of a given chip into multiple
> IDs per chip definition.
> Attached for Gmail users.
Thunderbird users also love this.

> -	{"AMD", "Am29F002(N)BB", AMD_ID, AM_29F002BB,
> +	{"AMD", "Am29F002(N)BB",
> +	 AMD_ID, AM_29F002BB, probe_jedec,
Please leave the chip name and ID on the same line. Once we fixed
flashrom to use the non-hidden IDs here, that'll be a very convenient
way for associating IDs and chips.
>  	 256, 256,
> -	 probe_jedec, erase_chip_jedec, write_en29f002a
> +	 erase_chip_jedec, write_en29f002a 
>  	},
I think function pointers should not be intercepted by the sized above.
This patch obfuscates the code.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 249 bytes
Desc: OpenPGP digital signature
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20081209/36575eb4/attachment.sig>

More information about the coreboot mailing list